Skip to content

fix(amazonq): early stop pagination requests when user decision is made #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2025
Merged

fix(amazonq): early stop pagination requests when user decision is made #7759

merged 4 commits into from
Jul 24, 2025

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jul 24, 2025 •
edited
Loading

Problem

When a paginated response is in flight, but the user already accepted or rejected a completion, the subsequent paginated requests should be cancelled.

This PR also fixes the codewhispererTotalShownTime being negative issue by using performance.now() across all timestamp computation.

Solution

This is not a user facing change.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner July 24, 2025 21:14
@github-actions
Copy link

github-actions bot commented Jul 24, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol changed the title fix: early stop pagination requests fix(amazonq): early stop pagination requests Jul 24, 2025
@leigaol leigaol changed the title fix(amazonq): early stop pagination requests fix(amazonq): early stop pagination requests when user decision is made Jul 24, 2025
Will-ShaoHua
Will-ShaoHua previously approved these changes Jul 24, 2025
View reviewed changes
@Will-ShaoHua Will-ShaoHua self-requested a review July 24, 2025 22:47
@leigaol leigaol merged commit 69516f4 into aws:master Jul 24, 2025
23 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leigaol @Will-ShaoHua